[chore] Optimize reduce_32 #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpwang
approved these changes
Dec 3, 2024
Hmm that means we will do the conversion even when the felt is just created. I suspect we will never enter the else branch |
I made it do a less than check only in the equal case, but I think we need it otherwise the cast is not deterministic. |
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Optimize reduce_32 * safety: static compiler CastFV max_bits bound * opt: handle equal bits case --------- Co-authored-by: Jonathan Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks: https://github.com/axiom-crypto/afs-prototype/blob/gh-pages/benchmarks-dispatch/refs/heads/chore/optimize-reduce32/fib_e2e-2-2-2-2-64cpu-linux-arm64-mimalloc.md
Reduced ~10% cells(368,077,146 -> 332,239,530) and ~8.4% proof time(392,937->360,299).